Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): windows-amd64 (Nim version-1-6) #1160

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Conversation

AlejandroCabeza
Copy link
Collaborator

@AlejandroCabeza AlejandroCabeza commented Jul 31, 2024

The failure is due to incompatibility (in caching) after Nimble's v.0.14.0 update, where they changed the dependencies directory name from pkgs to pkgs2.
This PR includes the nim branch in the cache key to avoid the directory name issue.

In the future, if we deprecate support for Nim 1.6 we may remove this.

fixes #1157

@AlejandroCabeza AlejandroCabeza self-assigned this Jul 31, 2024
@AlejandroCabeza AlejandroCabeza changed the title Fix windows test. fix(test): windows Jul 31, 2024
@diegomrsantos diegomrsantos changed the title fix(test): windows fix(ci): windows-amd64 (Nim version-1-6) Jul 31, 2024
@diegomrsantos diegomrsantos merged commit e5e319c into master Aug 1, 2024
9 of 12 checks passed
@diegomrsantos diegomrsantos deleted the fix/windows-1-6-test branch August 1, 2024 10:54
AlejandroCabeza added a commit that referenced this pull request Aug 1, 2024
* master:
  feat: adding onValidated observer (#1128)
  fix: add gcc 14 support (#1151)
  fix(ci): windows-amd64 (Nim version-1-6) (#1160)
AlejandroCabeza added a commit that referenced this pull request Aug 1, 2024
* master:
  feat: adding onValidated observer (#1128)
  fix: add gcc 14 support (#1151)
  fix(ci): windows-amd64 (Nim version-1-6) (#1160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

windows-amd64 (Nim version-1-6) is failing
3 participants