-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gossipsub): support version 1.2.0 #1106
Conversation
addresses issue #1102 |
dd65502
to
64f7ad8
Compare
This PR depends on this being fixed #1115, if we want to send |
This will be moved to a new PR cause of #1115. |
c44a9ea
to
dbfbc65
Compare
I'm not an expert on GS by any means, but I'm expecting something like |
I believe It seems that our current code can negotiate 1.0 but will still behave like 1.1, as there's no check on how the protocol should behave depending on the version negotiated with a remote peer. |
@@ -26,9 +26,9 @@ type | |||
|
|||
proc getPubSubPeer*(p: TestGossipSub, peerId: PeerId): PubSubPeer = | |||
proc getConn(): Future[Connection] = | |||
p.switch.dial(peerId, GossipSubCodec) | |||
p.switch.dial(peerId, GossipSubCodec_12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if dialing 1.2.0 fails? Should we attempt to dial with a lower version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only for tests. Production code tries all versions.
31b2dd1
to
3c6f983
Compare
4e76c9e
to
1ad54fd
Compare
template exclIfIt*[T](set: var HashSet[T], condition: untyped)
closes #1102