Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compilation issue when libp2p_expensive_metrics is enabled. #1014

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

diegomrsantos
Copy link
Collaborator

Fix compilation issue when libp2p_expensive_metrics is enabled.

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9468bb6) 83.17% compared to head (b959541) 83.13%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable    #1014      +/-   ##
============================================
- Coverage     83.17%   83.13%   -0.04%     
============================================
  Files            91       91              
  Lines         15342    15344       +2     
============================================
- Hits          12760    12757       -3     
- Misses         2582     2587       +5     
Files Coverage Δ
libp2p/protocols/pubsub/pubsubpeer.nim 93.12% <ø> (ø)
libp2p/protocols/pubsub/gossipsub.nim 88.08% <80.00%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes

@diegomrsantos diegomrsantos merged commit d46bcdb into unstable Jan 29, 2024
10 of 11 checks passed
@diegomrsantos diegomrsantos deleted the fix-compilation-issue branch January 29, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants