move to separate file to avoid interfering with hole punching test

tests/errorhelpers.nim

@@ -0,0 +1,27 @@
+import chronos
+
+proc allFuturesThrowing*[F: FutureBase](args: varargs[F]): Future[void] =
+  # This proc is only meant for use in tests / not suitable for general use.
+  # - Swallowing errors arbitrarily instead of aggregating them is bad design
+  # - It raises `CatchableError` instead of the union of the `futs` errors,
+  #   inflating the caller's `raises` list unnecessarily. `macro` could fix it
+  var futs: seq[F]
+  for fut in args:
+    futs &= fut
+  proc call() {.async.} =
+    var first: ref CatchableError = nil
+    futs = await allFinished(futs)
+    for fut in futs:
+      if fut.failed:
+        let err = fut.readError()
+        if err of Defect:
+          raise err
+        else:
+          if err of CancelledError:
+            raise err
+          if isNil(first):
+            first = err
+    if not isNil(first):
+      raise first
+
+  return call()

tests/helpers.nim

@@ -14,34 +14,8 @@ import ../libp2p/protocols/secure/secure
 import ../libp2p/switch
 import ../libp2p/nameresolving/[nameresolver, mockresolver]
 
-import ./asyncunit
-export asyncunit, mockresolver
-
-proc allFuturesThrowing*[F: FutureBase](args: varargs[F]): Future[void] =
-  # This proc is only meant for use in tests / not suitable for general use.
-  # - Swallowing errors arbitrarily instead of aggregating them is bad design
-  # - It raises `CatchableError` instead of the union of the `futs` errors,
-  #   inflating the caller's `raises` list unnecessarily. `macro` could fix it
-  var futs: seq[F]
-  for fut in args:
-    futs &= fut
-  proc call() {.async.} =
-    var first: ref CatchableError = nil
-    futs = await allFinished(futs)
-    for fut in futs:
-      if fut.failed:
-        let err = fut.readError()
-        if err of Defect:
-          raise err
-        else:
-          if err of CancelledError:
-            raise err
-          if isNil(first):
-            first = err
-    if not isNil(first):
-      raise first
-
-  return call()
+import "."/[asyncunit, errorhelpers]
+export asyncunit, errorhelpers, mockresolver
 
 const
   StreamTransportTrackerName = "stream.transport"

tests/hole-punching-interop/hole_punching.nim

@@ -12,7 +12,7 @@ import ../../libp2p/[builders,
                   protocols/connectivity/autonat/service,
                   protocols/ping]
 import ../stubs/autonatclientstub
-import ../helpers
+import ../errorhelpers
 
 proc createSwitch(r: Relay = nil, hpService: Service = nil): Switch =
   let rng = newRng()
@@ -48,7 +48,7 @@ proc main() {.async.} =
       isListener = getEnv("MODE") == "listen"
       switch = createSwitch(relayClient, hpservice)
       auxSwitch = createSwitch()
-      redisClient = open("redis", 6379.Port)
+      redisClient = open("localhost", 6379.Port)
 
     debug "Connected to redis"