Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update working days calculation #2197

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update working days calculation (if there is substituted holidays from another year) .
Close #2196.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (301185b) to head (ab08c1a).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          195       195           
  Lines        11755     11763    +8     
  Branches      1697      1700    +3     
=========================================
+ Hits         11755     11763    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PPsyrius
PPsyrius previously approved these changes Dec 27, 2024
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KJhellico I've updated the code as per your request.
Please review the changes when you get a chance.

holidays/groups/custom.py Outdated Show resolved Hide resolved
holidays/groups/custom.py Outdated Show resolved Hide resolved
@arkid15r arkid15r requested a review from PPsyrius December 28, 2024 02:59
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding to the queue.
@PPsyrius please review when you get a chance.

@arkid15r arkid15r enabled auto-merge (squash) December 28, 2024 20:18
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r merged commit dc9877b into vacanza:dev Dec 30, 2024
32 checks passed
@KJhellico KJhellico deleted the upd-substituted branch December 30, 2024 09:44
@arkid15r arkid15r mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect working days calculation in case of substituted holidays from another year
3 participants