Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Albania holidays, add l10n support #2104

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update Albania holidays, add l10n support (en_US, sq, uk).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

sonarcloud bot commented Nov 2, 2024

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aba7b09) to head (b06a10d).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2104   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          192       192           
  Lines        11563     11577   +14     
  Branches      1739      1741    +2     
=========================================
+ Hits         11563     11577   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇦🇱

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A couple of optional suggestions:

tests/countries/test_albania.py Show resolved Hide resolved
tests/countries/test_albania.py Show resolved Hide resolved
@arkid15r arkid15r added this pull request to the merge queue Nov 4, 2024
Merged via the queue into vacanza:dev with commit 0363e20 Nov 4, 2024
29 checks passed
@KJhellico KJhellico deleted the upd-albania branch November 4, 2024 18:34
@arkid15r arkid15r mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants