-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Australia holidays: remove Adelaide Cup Day
holiday pre-1973 for South Australia
#2082
Update Australia holidays: remove Adelaide Cup Day
holiday pre-1973 for South Australia
#2082
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2082 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 191 191
Lines 11546 11547 +1
Branches 1743 1744 +1
=========================================
+ Hits 11546 11547 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PPsyrius could you add the source to the code? I guess a comment above the elif
should be enough.
Thank you!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇦🇺 LGTM
Proposed change
According to Racing SA, Adelaide Cup Day has only gained its public holiday status in 1973.
Type of change
holidays
functionality in general)Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally