Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Australia holidays: remove Adelaide Cup Day holiday pre-1973 for South Australia #2082

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Oct 26, 2024

Proposed change

According to Racing SA, Adelaide Cup Day has only gained its public holiday status in 1973.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0adc4be) to head (54cbae7).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2082   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       191           
  Lines        11546     11547    +1     
  Branches      1743      1744    +1     
=========================================
+ Hits         11546     11547    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KJhellico
KJhellico previously approved these changes Oct 26, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PPsyrius could you add the source to the code? I guess a comment above the elif should be enough.

Thank you!

Copy link

sonarcloud bot commented Oct 26, 2024

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇦🇺 LGTM

@arkid15r arkid15r added this pull request to the merge queue Oct 26, 2024
Merged via the queue into vacanza:dev with commit 69c11a5 Oct 26, 2024
29 checks passed
@PPsyrius PPsyrius deleted the update_au_holidays_adelaide_cup branch October 26, 2024 18:07
@arkid15r arkid15r mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants