feat: add internal API for nested overlays to bringToFront #8690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/nested-overlay
branch
2 times, most recently
from
e2e8240 to
4c9abcb
Compare
web-padawan
force-pushed
the
feat/nested-overlay
branch
from
4c9abcb to
952f695
Compare
|
sissbruecker
approved these changes
Feb 19, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
web-padawan
added a commit
that referenced
this pull request
Feb 24, 2025
|
This ticket/PR has been released with Vaadin 24.7.0.alpha12 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #8521
Fixing the above issue where popover overlay ends up behind its parent dialog overlay requires us to add new APIs:
bringToFront()recursively for all its nested overlays once its ownbringToFront()is called),vaadin-popoverit should be basically the overlay where itstargetis attached (note thatvaadin-popoveritself can be elsewhere).This PR focuses on the first part. I'm going to create a separate PR as a follow-up with the actual fix for popover.
Type of change