Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add new variable doc and deprecate old one #8636

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

DiegoCardoso
Copy link
Contributor

Description

Adds:

  • missing documentation for --vaadin-form-layout-row-spacing styling variable
  • deprecation warning to the documentation of --vaadin-form-item-row-spacing styling variable

@DiegoCardoso DiegoCardoso requested a review from vursen February 4, 2025 15:10
Comment on lines 92 to 93
* `--vaadin-form-item-row-spacing` | (DEPRECATED: Use `--vaadin-form-layout-row-spacing` on `<vaadin-form-layout>`
* instead) Height of the spacing between the form item elements | `1em`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the entire description text on the same line, as otherwise it disrupts the table formattting in VS Code:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link

sonarqubecloud bot commented Feb 5, 2025

@DiegoCardoso DiegoCardoso merged commit d36b63b into main Feb 5, 2025
9 checks passed
@DiegoCardoso DiegoCardoso deleted the docs/form-layout/missing-variable-docs branch February 5, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants