refactor!: return a marker string to help Flow detect bad input #8413
Conversation
| * @private | ||
| */ | ||
| get __hasUnparsableValue() { | ||
| return this.inputElement.validity.badInput; | ||
| get __unparsableValue() { |
There was a problem hiding this comment.
I found the previous approach with the boolean getter a bit clearer, and it looks like we don't necessarily have to change this. Having an unparsable value string if the value is parsable is potentially confusing. A boolean expresses this clearer because either the value parsable or not, and that is all we are interested in.
There was a problem hiding this comment.
Thanks, I reverted the previous approach and also added an undefined check to the _inputElementValue getter that's necessary for the Flow ITs to pass.
| * @param {InputEvent} event | ||
| * @protected | ||
| */ | ||
| _setHasInputValue(event) { |
There was a problem hiding this comment.
Let's also remove this method from input-mixin.d.ts.
|
Description
This PR changes number fields to make the
_inputElementValuegetter return aNaNmarker string when input can't be parsed. This change will allow us to replace_hasInputValuewith_inputElementValuein Flow NumberField and then deprecate it in the web components. Previously, detecting bad input via_inputElementValuewasn't possible sinceinput[type=number]elements give an empty string for unparsable values.Since
_inputElementValueis a protected method, I marked this as a possible breaking changeType of change