Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide scroller completely when dragging large grids #8351

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Dec 16, 2024

Description

The PR introduces a new solution to replace the previous workaround, which applied min-height: 0 to the items container when dragging large grids. Instead, it now sets display: none on the scroller element. By completely hiding the grid content from the drag image, this change prevents crashes in Chromium browsers and improves performance in Safari. A similar change has also been applied to virtual-list.

The related Chromium issue: https://issues.chromium.org/issues/383356871

Fixes #8235

Type of change

  • Bugfix

@vursen vursen changed the title fix: replace default drag image with auto-generated one fix: hide scroller when dragging large grids Dec 17, 2024
@vursen vursen marked this pull request as ready for review December 17, 2024 09:07
@vursen vursen changed the title fix: hide scroller when dragging large grids fix: hide scroller completely when dragging large grids Dec 17, 2024
@web-padawan web-padawan merged commit eda141f into main Dec 17, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/improve-drag-workaround branch December 17, 2024 10:56
@vaadin-bot
Copy link
Collaborator

Hi @vursen and @web-padawan, when i performed cherry-pick to this commit to 23.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick eda141f
error: could not apply eda141f... fix: hide scroller completely when dragging large grids (#8351)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan pushed a commit that referenced this pull request Dec 17, 2024
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
web-padawan pushed a commit that referenced this pull request Dec 17, 2024
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance drop when scrolling and dragging grid [1 day]
5 participants