fix: ensure grid root cache has a valid size (#8525) (#8526)

Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
vaadin · Jan 17, 2025 · d4c59c9 · d4c59c9
1 parent 3de0ef2
commit d4c59c9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/grid/src/vaadin-grid-data-provider-mixin.js b/packages/grid/src/vaadin-grid-data-provider-mixin.js
@@ -384,7 +384,7 @@ export const DataProviderMixin = (superClass) =>
      */
     clearCache() {
       this._dataProviderController.clearCache();
-      this._dataProviderController.rootCache.size = this.size;
+      this._dataProviderController.rootCache.size = this.size || 0;
       this._dataProviderController.recalculateFlatSize();
       this._hasData = false;
       this.__updateVisibleRows();

diff --git a/packages/grid/test/data-provider.common.js b/packages/grid/test/data-provider.common.js
@@ -533,6 +533,13 @@ describe('data provider', () => {
           }
         });
 
+        it('should not jam on clear cache', () => {
+          grid.dataProvider = (params, callback) => {
+            setTimeout(() => finiteDataProvider(params, callback), 0);
+          };
+          grid.clearCache();
+        });
+
         it('should not render synchronously until all data requests have finished', (done) => {
           generateItemIds = true;
           grid.itemIdPath = 'id';