Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: input value getters and setters (CP: 14) #621

Merged
merged 4 commits into from
Apr 26, 2023

Conversation

mukherjeesudebi
Copy link
Contributor

@vursen
Copy link
Contributor

vursen commented Apr 26, 2023

The new getter/setter could be also used here:

this.value = this.inputElement.value = String(parseFloat(value));

const match = this.inputElement.value.match(this.pattern);

added new getter/setter to number-field and text-area
@mukherjeesudebi mukherjeesudebi changed the title refactor: input value getters and setters refactor: input value getters and setters (CP: 14) Apr 26, 2023
@vursen
Copy link
Contributor

vursen commented Apr 26, 2023

And also here:

if (!this.pattern || !this.inputElement.value) {

@vursen vursen merged commit 9731cfd into master Apr 26, 2023
@vursen vursen deleted the backport-move-input-value branch April 26, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants