Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change event #122

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Fix change event #122

merged 1 commit into from
Aug 27, 2019

Conversation

yuriy-fix
Copy link
Contributor

Description of the issue:
On text-change we are setting the __debounceSetValue which will change the value after 200ms. On focusout we are comparing __lastCommittedChange and current value and if they are not the same we are dispatching the change event.

But in case when the focusout will occur before 200ms timeout, debouncer will be flushed and on the focus check hasFocus() in the _valueChanged observer it will set the __lastCommittedChange to be the current value. It will lead to not dispatching change event.

The test are now using blur before focusout in order to properly check Quill's hasFocus

@yuriy-fix yuriy-fix merged commit e8d3d6a into master Aug 27, 2019
@alvarezguille alvarezguille deleted the fix-change-event branch July 16, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants