Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue:
On
text-change
we are setting the__debounceSetValue
which will change the value after 200ms. Onfocusout
we are comparing__lastCommittedChange
and currentvalue
and if they are not the same we are dispatching thechange
event.But in case when the
focusout
will occur before 200ms timeout, debouncer will be flushed and on the focus checkhasFocus()
in the_valueChanged
observer it will set the__lastCommittedChange
to be the current value. It will lead to not dispatchingchange
event.The test are now using
blur
beforefocusout
in order to properly check Quill'shasFocus