Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable dangerously setting html value #119

Merged
merged 2 commits into from
Jun 27, 2019

Conversation

yuriy-fix
Copy link
Contributor

@yuriy-fix yuriy-fix commented Jun 26, 2019

Fixes #68
Quill updated based on vaadin/quill#1


This change is Reviewable

@yuriy-fix yuriy-fix requested a review from web-padawan June 27, 2019 07:21
@web-padawan web-padawan changed the title Enable dangerously setting html value feat: enable dangerously setting html value Jun 27, 2019
@web-padawan
Copy link
Member

Marked as feat, as this is a new API which should be released under a new minor.
However, if for Flow counterpart this is considered a bug fix, we can agree on patch release.

@tomivirkki WDYT?

@web-padawan web-padawan requested a review from tomivirkki June 27, 2019 09:49
@tomivirkki
Copy link
Member

@web-padawan I think it's a new feature on both ends

@yuriy-fix yuriy-fix merged commit 6861a99 into master Jun 27, 2019
@web-padawan web-padawan deleted the dangerously-set-html-value branch July 16, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setter for htmlValue
3 participants