feat: Add specific component tags for avatar, text-area and button for better theming support #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 8, 2021 13:03
Own tag for avatar when used via vaadin-message, so that it can be themed.
Own tag for avatar when used via vaadin-message-input, so that it can be themed.
Own tag for button when used via vaadin-message-input, so that it can be themed.
A zero value should not have a unit.
web-padawan
requested changes
Mar 8, 2021
|
I have a problem. --vaadin-avatar-outline-width: 0px;It is a zero value and zero values should not have a unit. I changed the row to --vaadin-avatar-outline-width: 0;but that actually broke the implementation. Margin-right of the avatar was not anymore there. This is because it is used in a calc in :host {
margin-right: calc(var(--lumo-space-m) - var(--vaadin-avatar-outline-width));
margin-top: calc(var(--lumo-space-s) - var(--vaadin-avatar-outline-width));
}that evaluates with resolved variables to So now I'm unsure how to have to satisfy the linter correctly. |
web-padawan
reviewed
Mar 8, 2021
web-padawan
approved these changes
Mar 9, 2021
|
Tested in iOS Simulator locally and the tests are passing. Probably it was SauceLabs issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28