Add auto-scroll to latest message #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Feb 9, 2021
| @@ -59,7 +60,8 @@ class MessageListElement extends ElementMixin(ThemableMixin(PolymerElement)) { | |||
| type: Array, | |||
| value: function () { | |||
| return []; | |||
| } | |||
| }, | |||
| observer: '_itemsChanged' | |||
There was a problem hiding this comment.
A single property observer only handles the cases when the whole array is reset: messageList.items = []
But it does not cover updating the items with Polymer magic methods, e.g. messageList.push('items', {}).
Please consider using a multi-property observer instead, see vaadin-menu-bar for an example.
One downside of multi-propery observers is that you will not get an old value though.
There was a problem hiding this comment.
Thanks @web-padawan for the suggestion: we discussed this and decided to observe only the replacement of the whole array (also considering the future transition to Lit).
Peppe
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4.