Skip to content

Commit

Permalink
fix: remove extra margin and padding rules (#67)
Browse files Browse the repository at this point in the history
vaadin-message-input-button had margin:0 and vaadin-message-input-text-area padding:0.
These messed when you had these components next to Vaadin's other components, as their heights did not match.
  • Loading branch information
Peppe authored Mar 25, 2021
1 parent 104b8ac commit 641068a
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/vaadin-message-input-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ registerStyles(
css`
:host {
flex-shrink: 0;
margin: 0;
}
`,
{ moduleId: 'vaadin-message-input-button-styles' }
Expand Down
1 change: 0 additions & 1 deletion src/vaadin-message-input-text-area.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ registerStyles(
:host {
align-self: stretch;
flex-grow: 1;
padding: 0;
}
`,
{ moduleId: 'vaadin-message-input-text-area-styles' }
Expand Down
Binary file modified test/visual/screens/vaadin-message/lumo-message-input-ltr.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/visual/screens/vaadin-message/lumo-message-input-rtl.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/visual/screens/vaadin-message/material-message-input-ltr.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/visual/screens/vaadin-message/material-message-input-rtl.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 641068a

Please sign in to comment.