Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

CHARTS-693: Remove style config #56

Merged
merged 7 commits into from
Dec 5, 2017
Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 1, 2017

Removed unused Java style properties in favor of CSS styling.


This change is Reviewable

@ghost ghost requested review from DiegoCardoso and alvarezguille December 1, 2017 08:44
@ghost ghost changed the title Remove style config CHARTS-693: Remove style config Dec 1, 2017
@alvarezguille
Copy link
Member

Review status: 0 of 53 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


model/src/main/java/com/vaadin/addon/charts/model/Legend.java, line 14 at r1 (raw file):

private Number borderRadius;

quick test showed that this doesn't work in styled mode either


Comments from Reviewable

@alvarezguille
Copy link
Member

Reviewed 52 of 53 files at r1, 1 of 1 files at r2.
Review status: 52 of 53 files reviewed at latest revision, 1 unresolved discussion.


model/src/main/java/com/vaadin/addon/charts/model/Handles.java, line 16 at r2 (raw file):

public class Handles extends AbstractConfigurationObject {

should we skip this class generation?


model/src/main/java/com/vaadin/addon/charts/model/Legend.java, line 14 at r1 (raw file):

Previously, alvarezguille (Guille) wrote…

private Number borderRadius;

quick test showed that this doesn't work in styled mode either

my bad


Comments from Reviewable

@ghost
Copy link
Author

ghost commented Dec 5, 2017

Review status: 52 of 53 files reviewed at latest revision, 1 unresolved discussion.


model/src/main/java/com/vaadin/addon/charts/model/Handles.java, line 16 at r2 (raw file):

Previously, alvarezguille (Guille) wrote…

public class Handles extends AbstractConfigurationObject {

should we skip this class generation?

Done.


Comments from Reviewable

@alvarezguille
Copy link
Member

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@alvarezguille alvarezguille merged commit 1b6008d into master Dec 5, 2017
@alvarezguille alvarezguille deleted the remove-style-config branch December 5, 2017 12:24
alvarezguille added a commit that referenced this pull request Jul 21, 2020
Styles removed in #56 and #77 should've been added back in #351
@alvarezguille alvarezguille mentioned this pull request Jul 21, 2020
alvarezguille added a commit that referenced this pull request Jul 22, 2020
Styles removed in #56 and #77 should've been added back in #351
alvarezguille added a commit that referenced this pull request Jul 24, 2020
Styles removed in #56 and #77 should've been added back in #351
manolo pushed a commit to vaadin/flow-components that referenced this pull request Oct 5, 2020
vaadin/vaadin-charts-flow#56

* Remove unused config from example

* Removed Handles

Web-component: vaadin-charts
manolo pushed a commit to vaadin/flow-components that referenced this pull request Oct 6, 2020
vaadin/vaadin-charts-flow#56

* Remove unused config from example

* Removed Handles

Web-component: vaadin-charts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant