-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
Review status: 0 of 53 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. model/src/main/java/com/vaadin/addon/charts/model/Legend.java, line 14 at r1 (raw file):
quick test showed that this doesn't work in styled mode either Comments from Reviewable |
Reviewed 52 of 53 files at r1, 1 of 1 files at r2. model/src/main/java/com/vaadin/addon/charts/model/Handles.java, line 16 at r2 (raw file):
should we skip this class generation? model/src/main/java/com/vaadin/addon/charts/model/Legend.java, line 14 at r1 (raw file): Previously, alvarezguille (Guille) wrote…
my bad Comments from Reviewable |
…n-charts-flow into remove-style-config
Review status: 52 of 53 files reviewed at latest revision, 1 unresolved discussion. model/src/main/java/com/vaadin/addon/charts/model/Handles.java, line 16 at r2 (raw file): Previously, alvarezguille (Guille) wrote…
Done. Comments from Reviewable |
Reviewed 1 of 1 files at r3. Comments from Reviewable |
vaadin/vaadin-charts-flow#56 * Remove unused config from example * Removed Handles Web-component: vaadin-charts
vaadin/vaadin-charts-flow#56 * Remove unused config from example * Removed Handles Web-component: vaadin-charts
Removed unused Java style properties in favor of CSS styling.
This change is