-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not recalculate flex basis for hidden rows #159
fix: do not recalculate flex basis for hidden rows #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand it correctly that in Vaadin 23+ this problem doesn't happen due to ResizeObserver usage? If so, we might still want to add relevant tests to the monorepo.
The flickering is still there. So I also created a PR for the monorepo, targeting v24.0 and v23.3 as well. |
Description
Currently, when a board is set invisible, flex basis is still recalculated on resize. This causes flickering when toggling visibility. This PR makes the row recalculate flex basis only when it is visible. Note that if any resizing occurs while the element is hidden, it should be explicitly updated with a
redraw()
call similar to the grid columns.Fixes vaadin/flow-components#5005
See: Monorepo PR
Type of change
Checklist