Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(router): matching child not under first parent #438

Merged
merged 1 commit into from
Feb 24, 2020
Merged

test(router): matching child not under first parent #438

merged 1 commit into from
Feb 24, 2020

Conversation

platosha
Copy link
Contributor

@platosha platosha commented Feb 21, 2020 •
edited by vlukashov
Loading

Fixes #307

This change is Reviewable

@platosha platosha added the hilla label Feb 21, 2020
haijian-vaadin
haijian-vaadin approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@haijian-vaadin haijian-vaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@haijian-vaadin haijian-vaadin merged commit a382bab into master Feb 24, 2020
@haijian-vaadin haijian-vaadin deleted the test/matching-non-first-parent branch February 24, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haijian-vaadin haijian-vaadin haijian-vaadin approved these changes

Assignees
No one assigned
Labels
hilla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"page not found" when the matching route is not under the first matching parent
2 participants
@platosha @haijian-vaadin