Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure annotated endpoints works along Vaadin PUSH (CP: 1.1) #90

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: make sure annotated endpoints works along Vaadin PUSH (CP: 1.1) #90

merged 1 commit into from
Dec 7, 2022

Conversation

mcollovati
Copy link
Contributor

Description

The workaround added to make PUSH work in Quarkus prevents the usage of custom annotated websocket endpoint. This change allow them to work along Vaadin PUSH.

Fixes #78

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mcollovati
fix: make sure annotated endpoints works along Vaadin PUSH
ce475d7 
The workaround added to make PUSH work in Quarkus prevents the usage of custom
annotated websocket endpoint. This change allow them to work along Vaadin PUSH.

Fixes #78
@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mshabarov mshabarov merged commit aa4d741 into 1.1 Dec 7, 2022
@mshabarov mshabarov deleted the issues/78_annotated_websockets_1.1 branch December 7, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

@MarcinVaadin MarcinVaadin Awaiting requested review from MarcinVaadin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollovati @mshabarov