fix: make sure annotated endpoints works along Vaadin PUSH #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcinVaadin
previously approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Great that we now have covered custom web sockets with tests also on Quarkus. I've committed proposed changes to Flow, after releasing Flow with vaadin/flow#14694 we could remove JSR356_PATH_MAPPING_LENGTH from Quarkus.
mshabarov
previously approved these changes
Oct 4, 2022
The workaround added to make PUSH work in Quarkus prevents the usage of custom annotated websocket endpoint. This change allow them to work along Vaadin PUSH. Fixes #78
mcollovati
dismissed stale reviews from mshabarov and MarcinVaadin
via
a8b0366
mcollovati
force-pushed
the
issues/78_annotated_websockets
branch
from
210ac37
to
a8b0366
Compare
|
Update the PR to be compatible with Vaadin 24. @MarcinVaadin @mshabarov Please review it again to check if it is all ok |
mshabarov
reviewed
Dec 7, 2022
deployment/src/main/java/com/vaadin/quarkus/deployment/VaadinQuarkusProcessor.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
mshabarov
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The workaround added to make PUSH work in Quarkus prevents the usage of custom annotated websocket endpoint. This change allows them to work along Vaadin PUSH.
Fixes #78
Type of change
Checklist
Additional for
Featuretype of change