-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: get rid of ReadonlyDeep
type
#3201
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3201 +/- ##
==========================================
- Coverage 86.91% 86.91% -0.01%
==========================================
Files 118 118
Lines 8194 8191 -3
Branches 1256 1256
==========================================
- Hits 7122 7119 -3
Misses 1058 1058
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # package-lock.json
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Before, all
OpenAPIV3
types were wrapped inReadonlyDeep
wrapper to make them read-only. However, now, when we haveTransferTypesPlugin
, it looks overburdened and unnecessary. So I decided that it'd be better to just remove this type leaving raw OpenAPIV3 types. It also unwrapped several errors, so this PR contains fixes for them as well.PR Summary
Dependency Updates:
@vaadin/react-components
from version24.7.0-alpha7
to24.7.0-alpha8
inpackage.json
andpackages/ts/react-crud/package.json
(🤖).Type Definition Changes:
ReadonlyDeep
type from various type definitions in multiple files, includingGenerator.ts
,ReferenceResolver.ts
,Schema.ts
,EndpointMethodOperationProcessor.ts
,EndpointMethodRequestBodyProcessor.ts
,EndpointMethodResponseProcessor.ts
,EndpointProcessor.ts
,index.ts
ingenerator-plugin-backbone
, andindex.ts
ingenerator-plugin-model
.Code Improvements:
oneOf
array areReferenceSchema
inSubTypesPlugin
.SubTypesProcessor
to usereadonly
for theoneOf
parameter.These changes collectively simplify type definitions and improve the robustness of the code.