feat(connect): add support for File type in requests #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3189 +/- ##
==========================================
+ Coverage 86.69% 86.74% +0.05%
==========================================
Files 120 120
Lines 8155 8196 +41
Branches 1244 1260 +16
==========================================
+ Hits 7070 7110 +40
Misses 1071 1071
- Partials 14 15 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…h-Hilla-endpoints
…h-Hilla-endpoints
…h-Hilla-endpoints
…h-Hilla-endpoints
…h-Hilla-endpoints
Lodin
requested changes
Feb 3, 2025
packages/ts/frontend/src/Connect.ts
Outdated
| } else { | ||
| headers['Content-Type'] = 'application/json'; | ||
| body = | ||
| params !== undefined ? JSON.stringify(params, (_, value) => (value === undefined ? null : value)) : undefined; |
There was a problem hiding this comment.
We can make it a bit more readable.
Suggested change
| params !== undefined ? JSON.stringify(params, (_, value) => (value === undefined ? null : value)) : undefined; | |
| if (params) { | |
| body = JSON.stringify(params, (_, value) => (value === undefined ? null : value)) | |
| } |
Lodin
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Also, to make SonarCloud happy, you can wrap repeating test in the function and use it
…h-Hilla-endpoints
|
Lodin
approved these changes
Feb 4, 2025
Lodin
deleted the
feat/3132/Client-support-for-file-upload-with-Hilla-endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to multipart requests if a
Fileobject is found anywhere in the body object.Closes #3132