Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Do not use a .ts extension for snapshot #2797

Merged
merged 6 commits into from
Oct 8, 2024
Merged

test: Do not use a .ts extension for snapshot #2797

merged 6 commits into from
Oct 8, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Oct 7, 2024

Prevents 'nx graph' from parsing the TS file and deducing there is a dependency on generator-plugin-client

Prevents 'nx graph' from parsing the TS file and deducing there is a dependency on generator-plugin-client
@Artur- Artur- requested a review from Lodin October 7, 2024 13:49
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (5b63b90) to head (e936988).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2797   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files          81       81           
  Lines        2677     2677           
  Branches      686      686           
=======================================
  Hits         2471     2471           
  Misses        156      156           
  Partials       50       50           
Flag Coverage Δ
unittests 92.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Artur- Artur- merged commit e6fd0ce into main Oct 8, 2024
14 of 15 checks passed
@Artur- Artur- deleted the fix-loop branch October 8, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants