fix: remove onDisconnect callback from flux subscription #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2766 +/- ##
==========================================
- Coverage 92.30% 92.29% -0.02%
==========================================
Files 81 81
Lines 2678 2673 -5
Branches 683 683
==========================================
- Hits 2472 2467 -5
Misses 156 156
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
krissvaa
force-pushed
the
fix/remove-ondisconnect
branch
3 times, most recently
from
c080c27
to
ee664c5
Compare
cromoteca
approved these changes
Sep 27, 2024
krissvaa
force-pushed
the
fix/remove-ondisconnect
branch
from
ee664c5
to
8b5db9f
Compare
|
|
This ticket/PR has been released with Hilla 24.5.0.beta5 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove onDisconnect callback as for #2737 and later introduce the onConnectionStateChange callback.
Fixes: #398 and #2769