Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Extract code that creates window.Vaadin.views json #2755

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Sep 23, 2024

For #2751

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (a897599) to head (2d99432).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2755   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          81       81           
  Lines        2648     2648           
  Branches      666      666           
=======================================
  Hits         2502     2502           
  Misses        142      142           
  Partials        4        4           
Flag Coverage Δ
unittests 94.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 23, 2024

@taefi taefi requested a review from Lodin September 23, 2024 11:38
Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taefi taefi removed the request for review from Lodin September 23, 2024 11:42
@Artur- Artur- merged commit c62bf0d into main Sep 23, 2024
15 checks passed
@Artur- Artur- deleted the refactor-filejson branch September 23, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants