-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: send updates only when not rendering #2707
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
=======================================
Coverage 94.35% 94.35%
=======================================
Files 80 80
Lines 2551 2551
Branches 661 661
=======================================
Hits 2407 2407
Misses 140 140
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overal, LGTM!
Just added one minor comment.
Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
Quality Gate failedFailed conditions |
This ticket/PR has been released with Hilla 24.5.0.alpha15 and is also targeting the upcoming stable 24.5.0 version. |
React doesn't allow updates to state while rendering.
Reference
Fixes: #2643