feat: add onDisconnect callback to subscription #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2684 +/- ##
==========================================
+ Coverage 92.29% 92.33% +0.04%
==========================================
Files 76 76
Lines 2479 2492 +13
Branches 643 646 +3
==========================================
+ Hits 2288 2301 +13
Misses 144 144
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes: #398
taefi
changed the title
taefi
reviewed
Aug 30, 2024
|
Looks good overall. Please address the red build. |
taefi
approved these changes
Sep 2, 2024
|
|
This ticket/PR has been released with Hilla 24.5.0.alpha12 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onDisconnect callback is called on reconnect.
This allows the Flux Connection to call the registered onDisconnect callbacks on reconnect.
If the state is already
RECONNECTING, subsequent calls toonReconnectwill not trigger calling theonDisconnectcallbacks multiple times.Fixes: #398
Also as long-polling has issues with flux connections only websocket connection is supported.
Long polling can still be enabled by passing atmosphere options from Connect.ts