Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add NumberSignal IT #2632

Merged
merged 9 commits into from
Aug 1, 2024
Merged

test: add NumberSignal IT #2632

merged 9 commits into from
Aug 1, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Jul 26, 2024 •
edited
Loading

Fixes #2629

@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (b7dae13) to head (1fd4d34).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2632   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files          71       71           
  Lines        2266     2266           
  Branches      591      591           
=======================================
  Hits         2098     2098           
  Misses        121      121           
  Partials       47       47
Flag Coverage Δ
unittests 92.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi marked this pull request as ready for review July 27, 2024 21:28
@taefi taefi requested a review from cromoteca July 29, 2024 07:54
Lodin
Lodin requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@Lodin Lodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would like to transform the class with static methods to a list of functions since it's gonna be the final implementation

packages/java/tests/spring/react-signals/frontend/helper/NumberSignalServiceWrapper.ts Outdated Show resolved Hide resolved
packages/java/tests/spring/react-signals/frontend/routes.tsx Outdated Show resolved Hide resolved
@taefi taefi requested a review from Lodin July 31, 2024 13:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 31, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@taefi taefi merged commit 05e42ed into main Aug 1, 2024
15 checks passed
@taefi taefi deleted the taefi/add-fullstack-signals-IT branch August 1, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lodin Lodin Lodin approved these changes

@cromoteca cromoteca Awaiting requested review from cromoteca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Full-stack Signals] add integration tests
2 participants
@taefi @Lodin