Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not log debug info unless asked to #2549

Merged
merged 11 commits into from
Jul 1, 2024
Merged

fix: Do not log debug info unless asked to #2549

merged 11 commits into from
Jul 1, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jun 18, 2024

Fixes #2196

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.71%. Comparing base (ca6c731) to head (85ed897).

Files Patch % Lines
packages/ts/file-router/src/vite-plugin.ts 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2549      +/-   ##
==========================================
- Coverage   90.74%   90.71%   -0.03%     
==========================================
  Files          66       66              
  Lines        2646     2649       +3     
  Branches      526      528       +2     
==========================================
+ Hits         2401     2403       +2     
  Misses         77       77              
- Partials      168      169       +1     
Flag Coverage Δ
unittests 90.71% <87.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Lodin
Lodin previously approved these changes Jun 25, 2024
@Artur-
Copy link
Member Author

Artur- commented Jun 26, 2024

Not sure why coverage says what it says, but it probably does not matter much

@Lodin Lodin enabled auto-merge (squash) July 1, 2024 08:06
Copy link

sonarcloud bot commented Jul 1, 2024

@Lodin Lodin merged commit 210fae2 into main Jul 1, 2024
14 of 15 checks passed
@Lodin Lodin deleted the debug-if-asked-for branch July 1, 2024 08:18
@vaadin-bot
Copy link
Collaborator

Hi @Artur- and @Lodin, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 210fae2
error: could not apply 210fae2... fix: Do not log debug info unless asked to (#2549)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.5.0.alpha4 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug logging written as INFO
3 participants