Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): initialize value / defaultValue keys when rendering optional fields #2508

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

platosha
Copy link
Contributor

@platosha platosha commented Jun 6, 2024

Fixes #2339

@platosha platosha added hilla Issues related to Hilla target/main target/24.4 labels Jun 6, 2024
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (2.5@10da71f). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             2.5    #2508   +/-   ##
======================================
  Coverage       ?   94.53%           
======================================
  Files          ?       51           
  Lines          ?     3385           
  Branches       ?      477           
======================================
  Hits           ?     3200           
  Misses         ?      152           
  Partials       ?       33           
Flag Coverage Δ
unittests 94.53% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@platosha platosha requested a review from Lodin June 6, 2024 15:11
@Lodin
Copy link
Contributor

Lodin commented Jun 6, 2024

The base branch does not allow updates? 😦

@platosha
Copy link
Contributor Author

platosha commented Jun 6, 2024

The base branch does not allow updates? 😦

Fixed.

@platosha platosha merged commit 4935567 into 2.5 Jun 6, 2024
15 checks passed
@platosha platosha deleted the fix/optional-fields-cross-validation branch June 6, 2024 15:29
vaadin-bot pushed a commit that referenced this pull request Jun 6, 2024
vaadin-bot pushed a commit that referenced this pull request Jun 6, 2024
Lodin pushed a commit that referenced this pull request Jun 6, 2024
Lodin pushed a commit that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants