Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine-runtime): skip generating endpoints in prepare-frontend #2485

Merged
merged 1 commit into from
May 29, 2024
Merged

fix(engine-runtime): skip generating endpoints in prepare-frontend #2485

merged 1 commit into from
May 29, 2024

Conversation

platosha
Copy link
Contributor

No description provided.

@platosha platosha added the hilla Issues related to Hilla label May 29, 2024
@codecov Codecov
Copy link

codecov bot commented May 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (24.4@66a4bf7). Learn more about missing BASE report.

❗ Current head 1ca2a17 differs from pull request most recent head f18e31f

Please upload reports for the commit f18e31f to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##             24.4    #2485   +/-   ##
=======================================
  Coverage        ?   95.04%           
=======================================
  Files           ?       66           
  Lines           ?     4557           
  Branches        ?      662           
=======================================
  Hits            ?     4331           
  Misses          ?      182           
  Partials        ?       44
Flag Coverage Δ
unittests 95.04% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mcollovati
mcollovati previously approved these changes May 29, 2024
View reviewed changes
taefi
taefi previously approved these changes May 29, 2024
View reviewed changes
@platosha platosha dismissed stale reviews from taefi and mcollovati via f18e31f May 29, 2024 10:17
@platosha platosha requested a review from taefi May 29, 2024 10:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@platosha platosha merged commit d071f29 into 24.4 May 29, 2024
13 checks passed
@platosha platosha deleted the fix/skip-prepare-frontend branch May 29, 2024 11:03
ZheSun88 pushed a commit that referenced this pull request May 29, 2024
@platosha @ZheSun88
fix(engine-runtime): skip generating endpoints in prepare-frontend (#…
a6f8e57 
…2485)
ZheSun88 pushed a commit that referenced this pull request May 29, 2024
@vaadin-bot @platosha
fix(engine-runtime): skip generating endpoints in prepare-frontend (#…
62f7be1 
…2485) (CP: main) (#2487)

* fix(engine-runtime): skip generating endpoints in prepare-frontend (#2485)

* chore: update IT tests to use 24.5 components (#2486)

---------

Co-authored-by: Anton Platonov <platosha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati left review comments

@taefi taefi Awaiting requested review from taefi

Assignees
No one assigned
Labels
cherry-picked-main hilla Issues related to Hilla target/main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@platosha @mcollovati @taefi @vaadin-bot