fix: ignore absence of file-routes.json at startup in dev mode #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 66 66
Lines 4507 4507
Branches 645 645
=======================================
Hits 4287 4287
Misses 179 179
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Artur-
reviewed
May 14, 2024
packages/java/endpoint/src/main/java/com/vaadin/hilla/route/ClientRouteRegistry.java
Outdated
Show resolved
Hide resolved
Artur-
reviewed
May 14, 2024
packages/java/endpoint/src/main/java/com/vaadin/hilla/route/ClientRouteRegistry.java
Outdated
Show resolved
Hide resolved
Artur-
reviewed
May 15, 2024
packages/java/endpoint/src/main/java/com/vaadin/hilla/route/ClientRouteRegistry.java
Outdated
Show resolved
Hide resolved
Artur-
previously approved these changes
May 15, 2024
…ientRouteRegistry.java Co-authored-by: Artur <artur@vaadin.com>
ZheSun88
approved these changes
May 15, 2024
|
ZheSun88
added a commit
that referenced
this pull request
May 15, 2024
* fix: ignore absence of file-routes.json at startup in dev mode Fixes #2408 * apply suggestions from code review * Update packages/java/endpoint/src/main/java/com/vaadin/hilla/route/ClientRouteRegistry.java Co-authored-by: Artur <artur@vaadin.com> --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: Artur <artur@vaadin.com>
ZheSun88
added a commit
that referenced
this pull request
May 15, 2024
… (CP: 24.4) (#2426) fix: ignore absence of file-routes.json at startup in dev mode (#2423) * fix: ignore absence of file-routes.json at startup in dev mode Fixes #2408 * apply suggestions from code review * Update packages/java/endpoint/src/main/java/com/vaadin/hilla/route/ClientRouteRegistry.java --------- Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com> Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: Artur <artur@vaadin.com>
|
This ticket/PR has been released with Hilla 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2408
Type of change
Checklist