Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getter for presentationProvider in Grid.Column (#10323) #12060

Merged
merged 3 commits into from
Dec 18, 2020

Conversation

jdewaen
Copy link
Contributor

@jdewaen jdewaen commented Jul 31, 2020

Without access to the presentation provider used for a column, it is often not possible to reconstruct the data as shown on the end-user's screen

This PR adds a getter method to Grid.Column to allow access to this provider

Fixes #10323

Check when you have completed
[X] Valid tests for the pull request
[X] Contributing guidelines implemented


This change is Reviewable

Without access to the presentation provider used for a column, it is often not possible to reconstruct the data as shown on the end-user's screen

This commit adds a getter method to Grid.Column to allow access to this provider
@TatuLund TatuLund added this to the 8.13.0 milestone Oct 27, 2020
Copy link
Member

@Ansku Ansku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

The exact version will be added by a script during the release process.
Copy link
Member

@Ansku Ansku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Ansku Ansku merged commit a250bde into vaadin:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access to Grid.Column's presentationProvider
3 participants