Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove removed binding from changedBinding field #6827

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Nov 3, 2019

Fixes #5384


This change is Reviewable

@ujoni ujoni added the +0.0.1 label Nov 3, 2019
Copy link
Contributor

@ujoni ujoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained

@ujoni ujoni merged commit ccdd479 into master Nov 6, 2019
@ujoni ujoni added this to the 1.0 Maintenance milestone Nov 6, 2019
@ujoni ujoni deleted the 5384-binder branch November 6, 2019 08:55
ujoni pushed a commit that referenced this pull request Nov 7, 2019
ujoni pushed a commit that referenced this pull request Nov 7, 2019
ujoni pushed a commit that referenced this pull request Nov 7, 2019
ujoni pushed a commit that referenced this pull request Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binder.removeBinding issue
2 participants