Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce plugin-required dependencies and log incompatibilities (#20601) (CP: 24.4) #20606

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

…20601)

The Flow Maven Plugin uses a class loader that combines project and plugin
dependencies to ensure class scanning happens on runtime artifacts.
However, plugin execution may fail if the project defines dependency versions
incompatible with those used by the plugin.

This change enforces the use of plugin-defined versions for certain
dependencies not directly used by Flow at runtime. Additionally, it logs
potential incompatibilities for other dependencies if the build fails.

Fixes vaadin/mpr-demo#23
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) December 3, 2024 13:58
Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link

github-actions bot commented Dec 3, 2024

Test Results

1 119 files  ± 0  1 119 suites  ±0   1h 23m 30s ⏱️ + 6m 5s
7 093 tests ± 0  7 044 ✅ + 1  49 💤 ±0  0 ❌ ±0 
7 464 runs  +18  7 403 ✅ +19  61 💤 ±0  0 ❌ ±0 

Results for commit 4c24a43. ± Comparison against base commit 1ab8b04.

@vaadin-bot vaadin-bot merged commit edab36d into 24.4 Dec 3, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20601-to-24.4-1733233935050 branch December 3, 2024 14:10
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.4.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants