Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow issue #6349 (#20255) (CP: 23.5) #20281

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

…20255)

Commands enqueued by VaadinSession.access() in general have nothing to do with each other. The only thing they have in common is they share the same VaadinSession (and, by implication, VaadinService).

Therefore, if command №1 invoked UI.setCurrent() and command №2 invokes UI.getCurrent(), command №2 should read null, not the random UI from command №1 that it has nothing to do with.

Fixes #6349
Copy link

Copy link

Test Results

  963 files  ±0    963 suites  ±0   50m 39s ⏱️ - 3m 50s
6 309 tests +1  6 260 ✅ +1  49 💤 ±0  0 ❌ ±0 
6 571 runs  +1  6 516 ✅ +1  55 💤 ±0  0 ❌ ±0 

Results for commit 3f56cda. ± Comparison against base commit 45d0bca.

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit 875e768 into 23.5 Oct 18, 2024
24 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20255-to-23.5-1729238253290 branch October 18, 2024 08:16
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 23.5.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants