feat: Get menu views api #19355
Merged
feat: Get menu views api #19355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create MenuRegistry for getting automatic menu views for population. Fixes #19321
client routes get to start with /
Remove empty test.
caalador
force-pushed
the
issues/19321-menu-api
branch
from
2f011cf
to
bfa8575
Compare
caalador
force-pushed
the
issues/19321-menu-api
branch
from
0006429
to
297987c
Compare
Add collect server menu item methods. rename parameters to match used ones
caalador
added a commit
to vaadin/hilla
that referenced
this pull request
May 14, 2024
Unify the views.json to use the same names as createViewConfigJson generates. depends on vaadin/flow#19355 Part of #19321
tltv
requested changes
May 14, 2024
There was a problem hiding this comment.
I'm wondering would it make sense to add all active access control automatically if they exist in UI instance. Hilla could not use that because UI instance does not exist, but in Flow apps UI always exists and all access control objects can be used automatically.
Access control objects can be read into a List like this:
UI.getCurrent().getInternals()
.getListeners(BeforeEnterHandler.class).stream()
.filter(handler -> handler instanceof BeforeEnterListener)
.map(BeforeEnterListener.class::cast).toList()
Note that calling getListeners(BeforeEnterListener.class) would not work directly. It has to go via BeforeEnterHandler class.
Example in MenuListView IT.
All public methods, that don't take in a list of BeforeEnterListeners, can check if UI instance is available, and if it is, then use available AC instances by default.
flow-server/src/main/java/com/vaadin/flow/router/RouteConfiguration.java
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/menu/AvailableViewInfo.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/menu/MenuRegistry.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/menu/MenuRegistry.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/menu/MenuRegistry.java
Outdated
Show resolved
Hide resolved
add missing fields and fix constant usage. Add test for static method.
tltv
reviewed
May 14, 2024
flow-server/src/main/java/com/vaadin/flow/server/menu/MenuRegistry.java
Outdated
Show resolved
Hide resolved
|
caalador
added a commit
to vaadin/hilla
that referenced
this pull request
May 15, 2024
Unify the views.json to use the same names as createViewConfigJson generates. depends on vaadin/flow#19355 Part of #19321
caalador
added a commit
to vaadin/hilla
that referenced
this pull request
May 15, 2024
Unify the views.json to use the same names as createViewConfigJson generates. depends on vaadin/flow#19355 Part of #19321
tltv
approved these changes
May 15, 2024
taefi
added a commit
to vaadin/hilla
that referenced
this pull request
May 15, 2024
* feat: use Flow menu item collection Unify the views.json to use the same names as createViewConfigJson generates. depends on vaadin/flow#19355 Part of #19321 * Remove new extra filed from result --------- Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
AceDev24
pushed a commit
to AceDev24/hiliaGround
that referenced
this pull request
Sep 3, 2024
* feat: use Flow menu item collection Unify the views.json to use the same names as createViewConfigJson generates. depends on vaadin/flow#19355 Part of #19321 * Remove new extra filed from result --------- Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create MenuRegistry for getting
automatic menu views for population.
Fixes #19321