Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support top-level await #18772

Merged
merged 5 commits into from
Feb 21, 2024
Merged

feat: Support top-level await #18772

merged 5 commits into from
Feb 21, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Feb 21, 2024

Fixes #18575

Copy link

github-actions bot commented Feb 21, 2024

Test Results

1 094 files  ± 0  1 094 suites  ±0   1h 20m 46s ⏱️ + 1m 14s
6 925 tests + 2  6 877 ✅ + 2  48 💤 ±0  0 ❌ ±0 
7 282 runs  +24  7 222 ✅ +24  60 💤 ±0  0 ❌ ±0 

Results for commit 3f530e1. ± Comparison against base commit bddd220.

♻️ This comment has been updated with latest results.

@Artur- Artur- marked this pull request as ready for review February 21, 2024 12:44
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Artur- Artur- merged commit 1da4e65 into main Feb 21, 2024
26 checks passed
@Artur- Artur- deleted the toplevel-await branch February 21, 2024 14:34
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.

@Artur-
Copy link
Member Author

Artur- commented Sep 12, 2024

Top level await does not work properly even with this because of evanw/esbuild#253. I wonder if it would be better to revert it so you do not accidentally use it and it seems to work even though it does not

Artur- added a commit that referenced this pull request Sep 12, 2024
mshabarov pushed a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use top level await in projects
3 participants