test: Add/fix tests for binding cross-validation #18770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results1 094 files ± 0 1 094 suites ±0 1h 21m 21s ⏱️ + 3m 5s Results for commit e3e3816. ± Comparison against base commit 83c552a. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
mcollovati
requested changes
Feb 21, 2024
flow-data/src/test/java/com/vaadin/flow/data/binder/BinderTest.java
Outdated
Show resolved
Hide resolved
mcollovati
approved these changes
Feb 21, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
* test: Add/fix tests for binding cross-validation * Fix unintentional formatting changes
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
* test: Add/fix tests for binding cross-validation * Fix unintentional formatting changes
vaadin-bot
added a commit
that referenced
this pull request
Feb 21, 2024
vaadin-bot
added a commit
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and adds tests to ensure we don't get a regression like #18735.
Note to reviewer, if running these tests without this patch, the following test failures should happen: