fix: Remove fallback middleware also after Vite restart #18455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing hacky way of removing the middleware has two issues: 1. It removes it AFTER the first request to a non-existing file so the first request for a non-existing resources index.html and subsequent requests return 404 2. It does not work with Vite 4.0.5+ after restart, see vitejs/vite#15589
|
You can test the problem using |
|
mshabarov
approved these changes
Jan 22, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
The existing hacky way of removing the middleware has two issues: 1. It removes it AFTER the first request to a non-existing file so the first request for a non-existing resources index.html and subsequent requests return 404 2. It does not work with Vite 4.0.5+ after restart, see vitejs/vite#15589 Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
vaadin-bot
added a commit
that referenced
this pull request
Jan 22, 2024
) The existing hacky way of removing the middleware has two issues: 1. It removes it AFTER the first request to a non-existing file so the first request for a non-existing resources index.html and subsequent requests return 404 2. It does not work with Vite 4.0.5+ after restart, see vitejs/vite#15589 Co-authored-by: Artur <artur@vaadin.com> Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing hacky way of removing the middleware has two issues:
It removes it AFTER the first request to a non-existing file so the first request for a non-existing resources index.html and subsequent requests return 404
It does not work with Vite 4.0.5+ after restart, see Vite uses and passes a different server instance to plugins after server restart vitejs/vite#15589