feat: Allow excluding URLs from being handled by a root mapped Vaadin Spring servlet #14579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
force-pushed
the
exclude-urls-from-spring
branch
from
12d816d
to
27f2b7e
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
vaadin-spring/src/main/java/com/vaadin/flow/spring/VaadinConfigurationProperties.java
Outdated
Show resolved
Hide resolved
|
The swagger related tests pass on plain Spring but cannot be included by default because of the rule that forbids spring boot dependencies. The springdoc dependency brings in spring boot also to a plain spring project.. |
mcollovati
reviewed
Sep 23, 2022
...in-spring-tests/test-spring/src/main/java/com/vaadin/flow/spring/test/TestConfiguration.java
Outdated
Show resolved
Hide resolved
vaadin-spring/src/main/java/com/vaadin/flow/spring/VaadinServletConfiguration.java
Outdated
Show resolved
Hide resolved
… Spring servlet This makes it possible to make services like swagger work correctly even when Vaadin is mapped to the context root. Fixes #12949
Artur-
force-pushed
the
exclude-urls-from-spring
branch
from
0a1c1ee
to
f046a2e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mcollovati
approved these changes
Sep 28, 2022
This was referenced Oct 3, 2022
|
Yes, this issue has nothing to do with websockets |
|
This ticket/PR has been released with Vaadin 23.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to make services like swagger work correctly even when Vaadin is mapped to the context root.
Fixes #12949