Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent passing bad character to wp (#11099) #11116

Merged
merged 2 commits into from
May 31, 2021
Merged

fix: prevent passing bad character to wp (#11099) #11116

merged 2 commits into from
May 31, 2021

Conversation

pleku
Copy link
Contributor

@pleku pleku commented May 31, 2021

The webpack dev-server does not escape " character, as it is not valid
URL. This limitation was not checked when passing request to it via
DevModeHandlerImpl.

@pleku
fix: prevent passing bad character to wp (#11099)
d0044ff 
The webpack dev-server does not escape " character, as it is not valid
URL. This limitation was not checked when passing request to it via
DevModeHandlerImpl.
@pleku pleku requested a review from caalador May 31, 2021 07:48
caalador
caalador previously approved these changes May 31, 2021
View reviewed changes
@caalador caalador enabled auto-merge (squash) May 31, 2021 07:51
@caalador caalador disabled auto-merge May 31, 2021 07:55
@caalador caalador enabled auto-merge (squash) May 31, 2021 12:15
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 9 issues

  1. CRITICAL HandlerHelper.java#L19: Remove this unused import 'javax.servlet.http.HttpServletRequest'. rule
  2. MAJOR DevModeHandler.java#L462: Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. rule
  3. MAJOR DevModeHandler.java#L467: Invoke method(s) only conditionally. rule
  4. MAJOR DevModeHandler.java#L469: Invoke method(s) only conditionally. rule
  5. MAJOR DevModeHandler.java#L471: Invoke method(s) only conditionally. rule
  6. MAJOR DevModeHandler.java#L682: Invoke method(s) only conditionally. rule
  7. MAJOR DevModeHandler.java#L693: Either re-interrupt this method or rethrow the "InterruptedException". rule
  8. MAJOR HandlerHelper.java#L205: Define and throw a dedicated exception instead of using a generic one. rule
  9. MAJOR DevModeHandlerTest.java#L524: Remove this use of "Thread.sleep()". rule

@caalador caalador merged commit ca12a54 into 2.6 May 31, 2021
@caalador caalador deleted the cp/11099-2.6 branch May 31, 2021 13:07
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.6.2. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
Released with Platform 14.6.2 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pleku @vaadin-bot @caalador