Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add theme API to MessageListItem #979

Merged
merged 6 commits into from
May 18, 2021
Merged

feat: add theme API to MessageListItem #979

merged 6 commits into from
May 18, 2021

Conversation

pekam
Copy link
Contributor

@pekam pekam commented May 12, 2021

NOTE: This depends on #978 and won't pass in CI before that is merged.

Description

Feature: add and remove theme attribute values to messages in a MessageList. Only with strings at this point, since no theme variants have been implemented so far. The API is copied from HasTheme interface, which can be directly implemented only by component classes.

This enables developers to apply custom theming per each message in a MessageList.

Related issue: vaadin/collaboration-kit#30

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

pekam added 2 commits May 11, 2021 20:42
Only with strings at this point, since no theme
variants have been implemented so far.

This enables developers to apply custom theming
per each message in a MessageList.

Related issue: vaadin/collaboration-kit#30
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 2 issues

  1. MAJOR MessageListItem.java#L450: Make this anonymous inner class a lambda rule
  2. MINOR MessageListItem.java#L54: Make this value-based field transient so it is not included in the serialization of this class. rule

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 21.0.0.alpha2. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants