fix: update panes positions on Spreadsheet resize #6964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recalculate sheet position as part of the method triggered by the `ResizeObserver` configured on the Spreadsheet component. It fixes an issue where the panes positions are wrongly calculated when the component is attached to a hidden parent. Fixes #6932
tomivirkki
approved these changes
Dec 18, 2024
sissbruecker
approved these changes
Dec 18, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
DiegoCardoso
added a commit
that referenced
this pull request
Dec 18, 2024
…6968) Co-authored-by: Diego Cardoso <diego@vaadin.com>
DiegoCardoso
added a commit
that referenced
this pull request
Dec 18, 2024
…6969) Co-authored-by: Diego Cardoso <diego@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recalculate sheet position as part of the method triggered by the
ResizeObserverconfigured on the Spreadsheet component. It fixes an issue where the pane's positions are wrongly calculated when the component is attached to a hidden parent.Fixes #6932
Type of change