Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add setAriaLabel to Grid #6878

Merged
merged 3 commits into from
Dec 4, 2024
Merged

feat: add setAriaLabel to Grid #6878

merged 3 commits into from
Dec 4, 2024

Conversation

DiegoCardoso
Copy link
Contributor

@DiegoCardoso DiegoCardoso commented Nov 27, 2024

Description

Add setAriaLabel/getAriaLabel methods to Grid that uses the accessibleName property available in the web component to set the aria-label attribute on its internal <table> element.

Fixes vaadin/web-components#6749

Type of change

  • Bugfix
  • Feature

Add `setAriaLabel`/`getAriaLabel` methods to `Grid` that uses the
`accessibleName` property available in the web component to set the
`aria-label` attribute on its internal `<table>` element.

Fixes #6749
@DiegoCardoso DiegoCardoso marked this pull request as ready for review December 4, 2024 11:57
@DiegoCardoso DiegoCardoso enabled auto-merge (squash) December 4, 2024 13:35
Copy link

sonarqubecloud bot commented Dec 4, 2024

@DiegoCardoso DiegoCardoso merged commit 78da2f6 into main Dec 4, 2024
5 checks passed
@DiegoCardoso DiegoCardoso deleted the feat/grid/aria-label branch December 4, 2024 13:50
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.beta3 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aria-label API to Grid
3 participants