-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: restore hover effect on pie charts when using Lumo theme classes #6850
Conversation
|
||
States states = new States(); | ||
states.setHover(new Hover(false)); | ||
getPlotOptions().getPie().setStates(states); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added initially with vaadin/vaadin-charts-flow#393. From the Hover
JavaDoc I can not quite understand what the enabled
state is supposed to do, but apparently disabling it doesn't do anything sensible as it then marks all chart slices as inactive on hover. Removing this configuration seems to make the chart behave like any other without a theme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this was there since Charts for FW 7(? maybe).
From what I understand from the hover configuration, disabling it would still allow to hover the legend items and see the correspondent slice in the chart highlighted. But, by default, the legends in a pie chart show in the pie itself, so it should require some extra configuration to show the legend in a separate box, which is not expected.
This is how it would look like (you can check here):
pie-chart.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Fixes vaadin/web-components#8196