feat: configure min and max rows in text area #6828
Conversation
There was a problem hiding this comment.
Feels a bit strange that one property has a default value and does not allow null, while the other one doesn't have a default and does allow null. Though that mirrors what we have in the WC.
I guess we could change minRows to be nullable as well and document that it then uses 2 rows by default, though I'm not sure if that's better than having this inconsistency. Any opinions?
There was a problem hiding this comment.
I guess Integer.Max_VALUE or a negative number could be an alternative to null, but I would personally prefer null.
There was a problem hiding this comment.
We have a similar problem with setMaxLength, which is of type int and for that reason cannot be reset at all:
There was a problem hiding this comment.
Probably not very relevant either, I would assume the min/max rows configuration to usually be static.
...arent/vaadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/TextArea.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I guess Integer.Max_VALUE or a negative number could be an alternative to null, but I would personally prefer null.
…java/com/vaadin/flow/component/textfield/TextArea.java Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
|
|
This ticket/PR has been released with Vaadin 24.6.0.alpha4 and is also targeting the upcoming stable 24.6.0 version. |
Part of vaadin/web-components#1399